LEFT JOIN instead of JOIN for ApplicationSearch ordering
ClosedPublic
Actions

Authored by epriestley on Aug 2 2014, 8:35 AM.

Details

Reviewers

hach-que
btrahan

Maniphest Tasks

T4659: Cannot use custom "date" field for sorting

Commits

Restricted Diffusion Commit
rPeafd7070badb: LEFT JOIN instead of JOIN for ApplicationSearch ordering

Summary

Ref T4659. Because we JOIN, tasks with no value are filtered out. Instead, LEFT JOIN.

Test Plan

Issued an "Order by" and got all applicable tasks. Adjusted values and saw order change.

Diff Detail

Repository

rP Phabricator

Branch

leftjoin

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1999
Build 2000: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24340.Aug 2 2014, 8:35 AM

epriestley retitled this revision from to LEFT JOIN instead of JOIN for ApplicationSearch ordering.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: hach-que, btrahan.

epriestley added a task: T4659: Cannot use custom "date" field for sorting.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 2 2014, 8:35 AM

Harbormaster completed remote builds in B1999: Diff 24340.Aug 2 2014, 8:36 AM

hach-que accepted this revision.Aug 2 2014, 12:04 PM

hach-que edited edge metadata.

This revision is now accepted and ready to land.Aug 2 2014, 12:04 PM

Closed by commit rPeafd7070badb (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

query/

policy/

PhabricatorCursorPagedPolicyAwareQuery.php

2 lines

Diff 24340

View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

LEFT JOIN instead of JOIN for ApplicationSearch orderingClosedPublicActions