Page MenuHomePhabricator
Differential D10096

Move build status to the bottom of the property list
ClosedPublic
Actions

Authored by hach-que on Jul 31 2014, 8:49 AM.
Tags
None
Referenced Files
F14028594: D10096.id24296.diff
Fri, Nov 8, 2:19 PM
F13999565: D10096.id.diff
Thu, Oct 24, 3:37 PM
F13982397: D10096.id.diff
Sat, Oct 19, 10:59 PM
F13981527: D10096.diff
Sat, Oct 19, 5:10 PM
F13980772: D10096.id24278.diff
Sat, Oct 19, 12:28 PM
F13980765: D10096.id24296.diff
Sat, Oct 19, 12:28 PM
F13980728: D10096.id.diff
Sat, Oct 19, 12:22 PM
F13975602: D10096.diff
Fri, Oct 18, 10:54 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP8b5192ed713e: Move build status to the bottom of the property list
Summary

This moves the status property of the build to the bottom of the property list so that it matches the build targets.

Test Plan

Viewed a build, saw the status in the right position.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

hach-que updated this revision to Diff 24278.Jul 31 2014, 8:49 AM
hach-que retitled this revision from to Move build status to the bottom of the property list.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 31 2014, 8:49 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1964: Diff 24278.Jul 31 2014, 8:50 AM
epriestley accepted this revision.Jul 31 2014, 7:52 PM
epriestley edited edge metadata.

This seems important, maybe we should move the other one up instead?

This revision is now accepted and ready to land.Jul 31 2014, 7:52 PM
hach-que added a comment.Jul 31 2014, 10:05 PM

In the context of D10095, it makes more sense to have it at the bottom, otherwise it visually merges with the header colour. Keeping it further away from the header allows you to see it distinctly (and thus see the actual textual status and icon easier).

hach-que closed this revision.Jul 31 2014, 10:10 PM
hach-que updated this revision to Diff 24296.

Closed by commit rP8b5192ed713e (authored by @hach-que).

Revision Contents
Changeset List

PathSize
src/
applications/
harbormaster/
controller/
8 lines

Diff 24296

View Options

src/applications/harbormaster/controller/HarbormasterBuildViewController.php

Loading...
Phabricator · Built by Phacility