Differential D10092

Hide build target messages if there are no messages for the target
ClosedPublic
Actions

Authored by hach-que on Jul 31 2014, 4:54 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T1049: Implement Harbormaster

Commits

Restricted Diffusion Commit
rP298a30e647a8: Hide build target messages if there are no messages for the target

Summary

Ref T1049. This hides the build target messages area if there are no messages for the target. Since most of the time a build target won't recieve any messages, this area is confusing because it's always empty.

Test Plan

Viewed a build, saw the empty build target message areas disappear.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

hach-que updated this revision to Diff 24269.Jul 31 2014, 4:54 AM

hach-que retitled this revision from to Hide build target messages if there are no messages for the target.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

hach-que added a task: T1049: Implement Harbormaster.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 31 2014, 4:54 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1957: Diff 24269.Jul 31 2014, 4:55 AM

epriestley accepted this revision.Jul 31 2014, 7:39 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 31 2014, 7:39 PM

Closed by commit rP298a30e647a8 (authored by @hach-que).

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

controller/

HarbormasterBuildViewController.php

4 lines

Diff 24293

View Options

src/applications/harbormaster/controller/HarbormasterBuildViewController.php

Hide build target messages if there are no messages for the targetClosedPublicActions