Page MenuHomePhabricator
Differential D10090

Allow build steps to explicitly fail the build
ClosedPublic
Actions

Authored by hach-que on Jul 31 2014, 4:38 AM.
Tags
None
Referenced Files
F15461529: D10090.id.diff
Tue, Apr 1, 8:59 AM
F15454535: D10090.id.diff
Sat, Mar 29, 6:59 PM
F15452925: D10090.diff
Sat, Mar 29, 8:11 AM
F15451642: D10090.id24292.diff
Fri, Mar 28, 11:07 PM
F15450679: D10090.id24267.diff
Fri, Mar 28, 5:02 PM
F15443604: D10090.diff
Thu, Mar 27, 5:14 AM
F15441062: D10090.id24292.diff
Wed, Mar 26, 4:13 PM
F15441061: D10090.id24267.diff
Wed, Mar 26, 4:13 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPaa87a524e20f: Allow build steps to explicitly fail the build
Summary

We've received feedback that the "core - exception" is incredibly confusing, to the point where developers see this and write off the build failure as a Phabricator error that is unrelated to their changes.

Test Plan

Ran a build with a exit 1 run step, didn't see the "core - exception" appear.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

hach-que updated this revision to Diff 24267.Jul 31 2014, 4:38 AM
hach-que retitled this revision from to Allow build steps to explicitly fail the build.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 31 2014, 4:38 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1955: Diff 24267.Jul 31 2014, 4:39 AM
epriestley accepted this revision.Jul 31 2014, 7:42 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/harbormaster/worker/HarbormasterTargetWorker.php
75

We should probably make a STATUS_BROKEN / STATUS_ERROR of some kind for this, at some point.

This revision is now accepted and ready to land.Jul 31 2014, 7:42 PM
hach-que closed this revision.Jul 31 2014, 10:08 PM
hach-que updated this revision to Diff 24292.

Closed by commit rPaa87a524e20f (authored by @hach-que).

Revision Contents
Changeset List

Diff 24292

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/harbormaster/exception/HarbormasterBuildFailureException.php

Loading...
View Options

src/applications/harbormaster/step/HarbormasterCommandBuildStepImplementation.php

Loading...
View Options

src/applications/harbormaster/worker/HarbormasterTargetWorker.php

Loading...
Phabricator · Built by Phacility