Show status icon on build view
ClosedPublic
Actions

Authored by hach-que on Jul 31 2014, 6:27 AM.

Tags

None

Referenced Files

	F14486662: D10094.diff
	Tue, Dec 31, 7:51 PM

	Unknown Object (File)
	Tue, Dec 17, 8:48 AM

	Unknown Object (File)
	Sun, Dec 15, 1:40 PM

	Unknown Object (File)
	Wed, Dec 11, 3:53 AM

	Unknown Object (File)
	Mon, Dec 9, 8:35 AM

	Unknown Object (File)
	Nov 18 2024, 1:59 PM

	Unknown Object (File)
	Nov 8 2024, 7:05 PM

	Unknown Object (File)
	Nov 8 2024, 4:46 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP7e0edd8ef043: Show status icon on build view

Summary

This shows the status icon and color along side the build status on the build view controller.

Test Plan

Viewed a build, saw the icon appear.

Diff Detail

Repository

rP Phabricator

Branch

build-icon

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1961
Build 1962: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que updated this revision to Diff 24273.Jul 31 2014, 6:27 AM

hach-que retitled this revision from to Show status icon on build view.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 31 2014, 6:27 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1961: Diff 24273.Jul 31 2014, 6:28 AM

epriestley accepted this revision.Jul 31 2014, 6:25 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 31 2014, 6:25 PM

Closed by commit rP7e0edd8ef043 (authored by @hach-que).

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

controller/

HarbormasterBuildViewController.php

20 lines

Diff 24273

View Options

src/applications/harbormaster/controller/HarbormasterBuildViewController.php

Show status icon on build viewClosedPublicActions