This automatically hides any empty build logs from Harbormaster, so that they do not appear.
Details
Details
- Reviewers
epriestley chad - Group Reviewers
Blessed Reviewers - Commits
- Restricted Diffusion Commit
rPcefe30d7374d: Hide empty build logs
Viewed a build plan where the logs were empty and didn't see them appear.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- hide-empty-logs
- Lint
Lint Warnings Severity Location Code Message Warning src/applications/harbormaster/controller/HarbormasterBuildViewController.php:243 TXT3 Line Too Long Warning webroot/rsrc/js/application/harbormaster/behavior-show-empty-logs.js:1 JAVELIN5 `javelinsymbols` Not In Path - Unit
No Test Coverage - Build Status
Buildable 1960 Build 1961: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Can this use behavior-reveal-content instead?
Is there any reason users would want to show empty logs?
(I plan to do a general cleanup pass on most of the result UIs at some point, so I lean toward picking simpler fixes here...)
Comment Actions
I was discussing with my coworker yesterday as to "why would anyone ever want to view empty build logs?".
I think the conclusion we came to was that we want to know the presence of them, more than actually viewing them. That is, we want to know "the build target created a log and didn't output anything" vs "the build target hasn't created a log".
We did try a version that just hid them completely (without the option to show them), but it was not clear as to whether the build target had broken or done something weird, and it made it far less clear on what to do if you were trying to diagnose a build target.