We've received feedback that the "core - exception" is incredibly confusing, to the point where developers see this and write off the build failure as a Phabricator error that is unrelated to their changes.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- Restricted Diffusion Commit
rPaa87a524e20f: Allow build steps to explicitly fail the build
Ran a build with a exit 1 run step, didn't see the "core - exception" appear.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- exception-no-log
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 1955 Build 1956: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
| src/applications/harbormaster/worker/HarbormasterTargetWorker.php | ||
|---|---|---|
| 75 | We should probably make a STATUS_BROKEN / STATUS_ERROR of some kind for this, at some point. | |