Page MenuHomePhabricator
Differential D10089

Make artifacts imply dependencies on build steps
ClosedPublic
Actions

Authored by hach-que on Jul 31 2014, 2:03 AM.
Tags
None
Referenced Files
F14061614: D10089.diff
Mon, Nov 18, 7:32 AM
F14037075: D10089.diff
Sun, Nov 10, 1:42 PM
F14020045: D10089.diff
Tue, Nov 5, 11:54 PM
F13974801: D10089.id24264.diff
Oct 18 2024, 7:26 AM
F13973453: D10089.id24266.diff
Oct 18 2024, 12:58 AM
F13961721: D10089.id24265.diff
Oct 15 2024, 6:04 AM
Unknown Object (File)
Sep 17 2024, 2:51 PM
Unknown Object (File)
Sep 6 2024, 11:12 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP0f355756f5ca: Make artifacts imply dependencies on build steps
Summary

This makes input artifacts imply the appropriate build step dependencies in the build plan. That is, if you use a host artifact in a build step, it will then implicitly depend on the 'Lease Host' step.

Test Plan

Viewed the build plan with the artifacts, saw the dependencies. Ran a build, saw everything execute in the correct order.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

hach-que updated this revision to Diff 24264.Jul 31 2014, 2:03 AM
hach-que retitled this revision from to Make artifacts imply dependencies on build steps.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 31 2014, 2:03 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1953: Diff 24264.Jul 31 2014, 2:05 AM
epriestley accepted this revision.Jul 31 2014, 2:15 AM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/harbormaster/step/HarbormasterBuildStepImplementation.php
121

This should probably be array_merge(...), in case an artifact eventually has a numerical key which collides with a natural key in dependsOn.

This revision is now accepted and ready to land.Jul 31 2014, 2:15 AM
hach-que updated this revision to Diff 24265.Jul 31 2014, 2:26 AM
hach-que edited edge metadata.

Use array_merge

hach-que closed this revision.Jul 31 2014, 2:27 AM
hach-que updated this revision to Diff 24266.

Closed by commit rP0f355756f5ca (authored by @hach-que).

Harbormaster completed remote builds in B1954: Diff 24265.Jul 31 2014, 2:27 AM

Revision Contents
Changeset List

PathSize
src/
applications/
harbormaster/
controller/
1 line
engine/
3 lines
step/
34 lines

Diff 24266

View Options

src/applications/harbormaster/controller/HarbormasterPlanViewController.php

Loading...
View Options

src/applications/harbormaster/engine/HarbormasterBuildGraph.php

Loading...
View Options

src/applications/harbormaster/step/HarbormasterBuildStepImplementation.php

Loading...
Phabricator · Built by Phacility