Page MenuHomePhabricator
Differential D10089

Make artifacts imply dependencies on build steps
ClosedPublic
Actions

Authored by hach-que on Jul 31 2014, 2:03 AM.
Tags
None
Referenced Files
F19215207: D10089.diff
Dec 17 2025, 5:48 AM
F18821370: D10089.id24265.diff
Oct 22 2025, 10:32 PM
F18806986: D10089.id24266.diff
Oct 18 2025, 10:21 PM
F18784897: D10089.id.diff
Oct 13 2025, 3:41 PM
F18754490: D10089.id24266.diff
Oct 4 2025, 11:16 PM
F18680606: D10089.diff
Sep 26 2025, 2:54 AM
F18593664: D10089.id.diff
Sep 12 2025, 3:33 PM
F18581437: D10089.diff
Sep 11 2025, 6:10 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP0f355756f5ca: Make artifacts imply dependencies on build steps
Summary

This makes input artifacts imply the appropriate build step dependencies in the build plan. That is, if you use a host artifact in a build step, it will then implicitly depend on the 'Lease Host' step.

Test Plan

Viewed the build plan with the artifacts, saw the dependencies. Ran a build, saw everything execute in the correct order.

Diff Detail

Repository
rP Phabricator
Branch
artifactdeps
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1953
Build 1954: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que updated this revision to Diff 24264.Jul 31 2014, 2:03 AM
hach-que retitled this revision from to Make artifacts imply dependencies on build steps.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 31 2014, 2:03 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1953: Diff 24264.Jul 31 2014, 2:05 AM
epriestley accepted this revision.Jul 31 2014, 2:15 AM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/harbormaster/step/HarbormasterBuildStepImplementation.php
121

This should probably be array_merge(...), in case an artifact eventually has a numerical key which collides with a natural key in dependsOn.

This revision is now accepted and ready to land.Jul 31 2014, 2:15 AM
hach-que updated this revision to Diff 24265.Jul 31 2014, 2:26 AM
hach-que edited edge metadata.

Use array_merge

hach-que closed this revision.Jul 31 2014, 2:27 AM
hach-que updated this revision to Diff 24266.

Closed by commit rP0f355756f5ca (authored by @hach-que).

Harbormaster completed remote builds in B1954: Diff 24265.Jul 31 2014, 2:27 AM

Revision Contents
Changeset List

PathSize
src/
applications/
harbormaster/
controller/
1 line
engine/
3 lines
step/
34 lines

Diff 24264

View Options

src/applications/harbormaster/controller/HarbormasterPlanViewController.php

Loading...
View Options

src/applications/harbormaster/engine/HarbormasterBuildGraph.php

Loading...
View Options

src/applications/harbormaster/step/HarbormasterBuildStepImplementation.php

Loading...
Phabricator · Built by Phacility