Page MenuHomePhabricator
Differential D10045

Interpret "## text"-style Markdown headers
ClosedPublic
Actions

Authored by epriestley on Jul 24 2014, 11:34 PM.
Tags
None
Referenced Files
F13987106: D10045.id.diff
Mon, Oct 21, 7:31 AM
F13983967: D10045.id.diff
Sun, Oct 20, 10:00 AM
F13983965: D10045.id.diff
Sun, Oct 20, 10:00 AM
Unknown Object (File)
Oct 2 2024, 5:14 AM
Unknown Object (File)
Sep 27 2024, 5:49 AM
Unknown Object (File)
Sep 26 2024, 11:00 PM
Unknown Object (File)
Sep 26 2024, 10:57 PM
Unknown Object (File)
Sep 1 2024, 10:14 PM
View All Files
Subscribers
epriestley

Details

Reviewers
asherkin
btrahan
chad
Maniphest Tasks
T5102: Markdown syntax of README.md file present in a repository is not well rendered
Commits
rPHUfceef0248d67: Interpret "## text"-style Markdown headers
Summary

Ref T5102. This conflicts with # lists, but we can resolve the ambiguity with a reasonable heuristic.

Test Plan

Added and executed unit tests.

Diff Detail

Repository
rPHU libphutil
Branch
list3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1881
Build 1882: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24141.Jul 24 2014, 11:34 PM
epriestley retitled this revision from to Interpret "## text"-style Markdown headers.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: asherkin, chad, btrahan.
epriestley added a task: T5102: Markdown syntax of README.md file present in a repository is not well rendered.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 24 2014, 11:34 PM
Harbormaster completed remote builds in B1881: Diff 24141.Jul 24 2014, 11:35 PM
chad accepted this revision.Jul 25 2014, 4:07 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 25 2014, 4:07 AM
epriestley closed this revision.Jul 25 2014, 4:58 AM
epriestley updated this revision to Diff 24166.

Closed by commit rPHUfceef0248d67 (authored by @epriestley).

Revision Contents
Changeset List

Diff 24141

View Options

src/markup/engine/__tests__/remarkup/list-header-last.txt

Loading...
View Options

src/markup/engine/__tests__/remarkup/list-header.txt

Loading...
View Options

src/markup/engine/__tests__/remarkup/list-then-a-list.txt

Loading...
View Options

src/markup/engine/__tests__/remarkup/monospaced-in-monospaced.txt

Loading...
View Options

src/markup/engine/__tests__/remarkup/monospaced.txt

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupHeaderBlockRule.php

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupEngineRemarkupListBlockRule.php

Loading...
Phabricator · Built by Phacility