Differential D10040

Use celerity for document_black.png in PhabricatorStandardPageView
ClosedPublic
Actions

Authored by bttelle on Jul 24 2014, 10:14 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP3927e669594d: Use celerity for document_black.png in PhabricatorStandardPageView

Summary

The image was incorrectly served on /rsrc without using celerity. This
is no longer routable with recommendations in D9401.

Test Plan

Browse to home page and inspect javascript link for this resource.

Diff Detail

Repository

rP Phabricator

Branch

docpng

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1876
Build 1877: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

bttelle updated this revision to Diff 24131.Jul 24 2014, 10:14 PM

bttelle retitled this revision from to Use celerity for document_black.png in PhabricatorStandardPageView.

bttelle updated this object.

bttelle edited the test plan for this revision. (Show Details)

bttelle added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 24 2014, 10:14 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1876: Diff 24131.Jul 24 2014, 10:15 PM

epriestley accepted this revision.Jul 24 2014, 10:19 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 24 2014, 10:19 PM

Closed by commit rP3927e669594d (authored by Joseph Battelle <git@bttelle.com>, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

view/

page/

PhabricatorStandardPageView.php

4 lines

Diff 24131

View Options

src/view/page/PhabricatorStandardPageView.php

Use celerity for document_black.png in PhabricatorStandardPageViewClosedPublicActions