Page MenuHomePhabricator
Differential D10025

Allowing custom fields to be passed in over get for new tasks
Needs RevisionPublic
Actions

Authored by bluehawk on Jul 22 2014, 11:21 PM.
Tags
None
Referenced Files
F14024634: D10025.id24088.diff
Thu, Nov 7, 11:13 AM
F14023343: D10025.diff
Thu, Nov 7, 1:11 AM
F14013636: D10025.id24088.diff
Sat, Nov 2, 8:10 AM
F14004621: D10025.id24088.diff
Sat, Oct 26, 11:52 PM
F14003910: D10025.diff
Sat, Oct 26, 12:36 PM
F13962408: D10025.id24113.diff
Tue, Oct 15, 9:53 AM
Unknown Object (File)
Oct 2 2024, 2:12 PM
Unknown Object (File)
Sep 26 2024, 2:57 PM
View All Files
Subscribers
epriestley
Korvin
locutus

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

Pass in custom fields to tasks in the url e.g. &custom:field=blah

Test Plan

Try creating a task by going to a url and put some custom fields in the url

Diff Detail

Repository
rP Phabricator
Branch
custom-field-url
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 1851
Build 1852: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

bluehawk updated this revision to Diff 24088.Jul 22 2014, 11:21 PM
bluehawk retitled this revision from to Allowing custom fields to be passed in over get for new tasks.
bluehawk updated this object.
bluehawk edited the test plan for this revision. (Show Details)
bluehawk added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 22 2014, 11:21 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1851: Diff 24088.Jul 22 2014, 11:23 PM
bluehawk added a comment.Jul 23 2014, 6:33 PM

Okay just kidding, this is very bad.

When you edit a task, it sets all custom fields to blank. (Because it's not a post, it tries to read it from the request, but the request has no data). I'll investigate a fix shortly.

bluehawk planned changes to this revision.Jul 23 2014, 6:33 PM
bluehawk updated this revision to Diff 24112.Jul 23 2014, 7:27 PM
bluehawk edited edge metadata.

Fix so that custom fields don't show up empty when editing

bluehawk updated this revision to Diff 24113.Jul 23 2014, 7:28 PM

Updating comment

Harbormaster completed remote builds in B1865: Diff 24112.Jul 23 2014, 7:28 PM
Harbormaster completed remote builds in B1866: Diff 24113.
locutus added a subscriber: locutus.Jul 24 2014, 3:09 PM
epriestley requested changes to this revision.Nov 2 2015, 4:51 PM
epriestley edited edge metadata.

The upstream path for this lies beyond T9132.

This revision now requires changes to proceed.Nov 2 2015, 4:51 PM

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
controller/
7 lines

Diff 24088

View Options

src/applications/maniphest/controller/ManiphestTaskEditController.php

Loading...
Phabricator · Built by Phacility