Emit more usable results from phrequent.tracking
ClosedPublic
Actions

Authored by epriestley on Jul 16 2014, 12:02 AM.

Details

Reviewers

hach-que

Commits

Restricted Diffusion Commit
rPab3c17a2cd97: Emit more usable results from phrequent.tracking

Summary

I think this pretty much does what you would expect?

The "active" item is always at the top of the stack.

Test Plan

Called phrequent.tracking and got reasonable results.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 23845.Jul 16 2014, 12:02 AM

epriestley retitled this revision from to Emit more usable results from phrequent.tracking.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: hach-que.

Herald added a subscriber: epriestley. · View Herald TranscriptJul 16 2014, 12:02 AM

Harbormaster completed remote builds in B1703: Diff 23845.Jul 16 2014, 12:03 AM

I hooked up my patch to use this, and observed these incorrect calculations:

[arcpatch-D7327] james@james-laptop:~/Projects/Phabricator/arcanist> arc --conduit-uri=http://phabricator.local/ time
Status        Tracked Name          
(In Progress)     6 s T2: test again
(Suspended)       1 m D8: blah      
(Suspended)       4 s D7: blah      
[arcpatch-D7327] james@james-laptop:~/Projects/Phabricator/arcanist> arc --conduit-uri=http://phabricator.local/ stop D8
Stopped:  D8: blah

Status        Tracked Name          
(In Progress)    10 s T2: test again
(Suspended)       1 m D7: blah

After stopping D8, D7 shows an increase to 1 minute, but it should show 4 seconds instead.

hach-que added inline comments.Jul 16 2014, 8:26 AM