I think this pretty much does what you would expect?
The "active" item is always at the top of the stack.
Details
Details
- Reviewers
hach-que - Commits
- Restricted Diffusion Commit
rPab3c17a2cd97: Emit more usable results from phrequent.tracking
Called phrequent.tracking and got reasonable results.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- phrequent1
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 1725 Build 1726: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
I hooked up my patch to use this, and observed these incorrect calculations:
[arcpatch-D7327] james@james-laptop:~/Projects/Phabricator/arcanist> arc --conduit-uri=http://phabricator.local/ time Status Tracked Name (In Progress) 6 s T2: test again (Suspended) 1 m D8: blah (Suspended) 4 s D7: blah [arcpatch-D7327] james@james-laptop:~/Projects/Phabricator/arcanist> arc --conduit-uri=http://phabricator.local/ stop D8 Stopped: D8: blah Status Tracked Name (In Progress) 10 s T2: test again (Suspended) 1 m D7: blah
After stopping D8, D7 shows an increase to 1 minute, but it should show 4 seconds instead.
| src/applications/phrequent/conduit/ConduitAPI_phrequent_tracking_Method.php | ||
|---|---|---|
| 34 | I think this is the cause of the 1 minute issue, because the calculations need to know about the stopped D8 entry. | |
| src/applications/phrequent/conduit/ConduitAPI_phrequent_tracking_Method.php | ||
|---|---|---|
| 34 | Actually removing this doesn't fix it (it just makes things worse). | |
Comment Actions
- Fix bug which would cause ended, preempting events to not be considered preempting.
- Add some test coverage.
- Rename file.
Comment Actions
Tested this and got the intended results. D7327 has already been updated to use this new API.