Recover from a broken external OAuth2 account
ClosedPublic
Actions

Authored by epriestley on Jul 15 2014, 8:32 PM.

Details

Reviewers

btrahan
chad

Commits

Restricted Diffusion Commit
rP7ac5abb97934: Recover from a broken external OAuth2 account

Summary

Currently, the external accounts page can die in a fire if an OAuth2 link is bad. Instead of exploding, just fail the specific link.

Test Plan

Faked an error and got "invalid token" instead of an exception.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 23841.Jul 15 2014, 8:32 PM

epriestley retitled this revision from to Recover from a broken external OAuth2 account.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptJul 15 2014, 8:32 PM

Harbormaster completed remote builds in B1700: Diff 23841.Jul 15 2014, 8:33 PM

chad accepted this revision.Jul 15 2014, 8:35 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jul 15 2014, 8:35 PM

Specifically, Asana is hitting this on their install, with a user that has a bad refresh token. Digging into it with them, but the root issue here is clearly on our side.

Closed by commit rP7ac5abb97934 (authored by Evan Priestley <epriestley@orbital.(none)>).

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

provider/

PhabricatorAuthProviderOAuth2.php

15 lines

Diff 23842

View Options

src/applications/auth/provider/PhabricatorAuthProviderOAuth2.php

Recover from a broken external OAuth2 accountClosedPublicActions