Page MenuHomePhabricator
Differential D9891

Modernize "owner" typeahead datasource
ClosedPublic
Actions

Authored by epriestley on Jul 11 2014, 4:32 AM.
Tags
None
Referenced Files
F14355746: D9891.id.diff
Thu, Dec 19, 6:15 PM
F14352038: D9891.id23942.diff
Thu, Dec 19, 12:37 PM
Unknown Object (File)
Sun, Dec 15, 7:00 PM
Unknown Object (File)
Wed, Dec 11, 6:36 AM
Unknown Object (File)
Mon, Dec 9, 6:11 PM
Unknown Object (File)
Tue, Dec 3, 12:45 AM
Unknown Object (File)
Tue, Dec 3, 12:44 AM
Unknown Object (File)
Tue, Dec 3, 12:44 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4420: Modernize typeahead datasources
Commits
Restricted Diffusion Commit
rP7f0fb63c4450: Modernize "owner" typeahead datasource
Summary

Ref T4420. This one is users plus "upforgrabs". I renamed that to "none" and gave it a special visual style to make it more discoverable. Future diffs will improve this.

Test Plan
  • Used it in global search.
  • Used it in batch editor.

Diff Detail

Repository
rP Phabricator
Branch
tok7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1636
Build 1637: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 23748.Jul 11 2014, 4:32 AM
epriestley retitled this revision from to Modernize "owner" typeahead datasource.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T4420: Modernize typeahead datasources.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 11 2014, 4:32 AM
Harbormaster completed remote builds in B1636: Diff 23748.Jul 11 2014, 4:33 AM
epriestley updated this revision to Diff 23753.Jul 11 2014, 11:10 AM
  • Also remove route for old controller.
Harbormaster completed remote builds in B1641: Diff 23753.Jul 11 2014, 11:11 AM
btrahan accepted this revision.Jul 17 2014, 10:27 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 17 2014, 10:27 PM
epriestley closed this revision.Jul 17 2014, 10:49 PM
epriestley updated this revision to Diff 23942.

Closed by commit rP7f0fb63c4450 (authored by @epriestley).

Revision Contents
Changeset List

Diff 23748

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestBatchEditController.php

Loading...
View Options

src/applications/search/query/PhabricatorSearchApplicationSearchEngine.php

Loading...
View Options

src/applications/typeahead/controller/PhabricatorTypeaheadCommonDatasourceController.php

Loading...
View Options

src/applications/typeahead/datasource/PhabricatorTypeaheadNoOwnerDatasource.php

Loading...
View Options

src/applications/typeahead/datasource/PhabricatorTypeaheadOwnerDatasource.php

Loading...
View Options

src/view/form/control/AphrontFormTokenizerControl.php

Loading...
Phabricator · Built by Phacility