Page MenuHomePhabricator
Differential D9890

Remove "searchproject" typeahead datasource
ClosedPublic
Actions

Authored by epriestley on Jul 11 2014, 4:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 12:40 AM
Unknown Object (File)
Tue, Dec 17, 9:49 PM
Unknown Object (File)
Mon, Dec 9, 11:07 AM
Unknown Object (File)
Mon, Dec 9, 9:49 AM
Unknown Object (File)
Sat, Dec 7, 9:02 PM
Unknown Object (File)
Wed, Dec 4, 7:17 PM
Unknown Object (File)
Wed, Dec 4, 3:53 PM
Unknown Object (File)
Wed, Dec 4, 12:43 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4420: Modernize typeahead datasources
Commits
Restricted Diffusion Commit
rP27daa116c2ec: Remove "searchproject" typeahead datasource
Summary

Ref T4420. This is just "project", plus the special "no project" token, but that doesn't actually work. Replace it with a normal project typeahead. This is only used in Maniphest's reports.

Test Plan

Searched for a couple of projects in reports.

Diff Detail

Repository
rP Phabricator
Branch
tok6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1635
Build 1636: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 23747.Jul 11 2014, 4:17 AM
epriestley retitled this revision from to Remove "searchproject" typeahead datasource.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T4420: Modernize typeahead datasources.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 11 2014, 4:17 AM
Harbormaster completed remote builds in B1635: Diff 23747.Jul 11 2014, 4:19 AM
btrahan accepted this revision.Jul 17 2014, 10:27 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 17 2014, 10:27 PM
epriestley closed this revision.Jul 17 2014, 10:48 PM
epriestley updated this revision to Diff 23941.

Closed by commit rP27daa116c2ec (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
controller/
2 lines
typeahead/
controller/
39 lines
view/
form/
control/
1 line

Diff 23747

View Options

src/applications/maniphest/controller/ManiphestReportController.php

Loading...
View Options

src/applications/typeahead/controller/PhabricatorTypeaheadCommonDatasourceController.php

Loading...
View Options

src/view/form/control/AphrontFormTokenizerControl.php

Loading...
Phabricator · Built by Phacility