Page MenuHomePhabricator
Differential D9876

Modernize "legalpad" typeahead datasource
ClosedPublic
Actions

Authored by epriestley on Jul 10 2014, 8:58 PM.
Tags
None
Referenced Files
F14357590: D9876.diff
Fri, Dec 20, 5:52 AM
Unknown Object (File)
Wed, Dec 18, 12:12 AM
Unknown Object (File)
Wed, Dec 4, 7:50 AM
Unknown Object (File)
Wed, Dec 4, 7:39 AM
Unknown Object (File)
Tue, Dec 3, 12:23 AM
Unknown Object (File)
Tue, Dec 3, 12:23 AM
Unknown Object (File)
Tue, Dec 3, 12:22 AM
Unknown Object (File)
Tue, Dec 3, 12:06 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4420: Modernize typeahead datasources
Commits
Restricted Diffusion Commit
rP4e7798464435: Modernize "legalpad" typeahead datasource
Summary

Ref T4420. Modernize legalpad.

Test Plan
  • Used typeahead in Herald rules.
  • Used typeahead in Policy dialog.

Diff Detail

Repository
rP Phabricator
Branch
tok3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1614
Build 1615: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 23715.Jul 10 2014, 8:58 PM
epriestley retitled this revision from to Modernize "legalpad" typeahead datasource.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T4420: Modernize typeahead datasources.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 10 2014, 8:58 PM
Harbormaster completed remote builds in B1614: Diff 23715.Jul 10 2014, 8:59 PM
btrahan accepted this revision.Jul 10 2014, 10:30 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 10 2014, 10:30 PM
epriestley closed this revision.Jul 10 2014, 11:18 PM
epriestley updated this revision to Diff 23727.

Closed by commit rP4e7798464435 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
3 lines
applications/
herald/
controller/
31 lines
legalpad/
phid/
7 lines
typeahead/
33 lines
policy/
rule/
6 lines
typeahead/
controller/
16 lines

Diff 23715

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/herald/controller/HeraldRuleController.php

Loading...
View Options

src/applications/legalpad/phid/PhabricatorLegalpadPHIDTypeDocument.php

Loading...
View Options

src/applications/legalpad/typeahead/LegalpadDocumentDatasource.php

Loading...
View Options

src/applications/policy/rule/PhabricatorPolicyRuleLegalpadSignature.php

Loading...
View Options

src/applications/typeahead/controller/PhabricatorTypeaheadCommonDatasourceController.php

Loading...
Phabricator · Built by Phacility