Page MenuHomePhabricator

Modernize "repositories" typeahead datasource
ClosedPublic

Authored by epriestley on Jul 10 2014, 8:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 5:27 PM
Unknown Object (File)
Fri, Dec 20, 12:48 PM
Unknown Object (File)
Fri, Dec 20, 11:36 AM
Unknown Object (File)
Fri, Dec 20, 6:31 AM
Unknown Object (File)
Sun, Dec 15, 1:33 PM
Unknown Object (File)
Wed, Dec 11, 2:08 AM
Unknown Object (File)
Tue, Dec 10, 3:16 AM
Unknown Object (File)
Sun, Dec 8, 6:48 PM
Subscribers

Details

Summary

Ref T4420.

  • Allow tokenizers to accept either a Datasource object (new style) or a URI (old style).
  • Read URI and placeholder text from object, if available.
  • Swap the "repositories" datasource (which seemed like the simplest one) over to the new stuff.
  • Tweak/update the repo tokens a little bit.
Test Plan
  • Used tokenizer in Herald, Differential (search), Differential (edit), Push Logs.
  • Grepped for other callsites.

Diff Detail

Repository
rP Phabricator
Branch
tok1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1609
Build 1610: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Modernize "repositories" typeahead datasource.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
  • Also remove it from the old datasource.
  • Implement getDatasourceApplicationClass() properly.
btrahan edited edge metadata.

I dig the new pattern.

This revision is now accepted and ready to land.Jul 10 2014, 10:30 PM
epriestley updated this revision to Diff 23725.

Closed by commit rP34628002fd96 (authored by @epriestley).