Page MenuHomePhabricator

Parameterize `@{upstream}` in arc to fix Windows
ClosedPublic

Authored by epriestley on Jul 9 2014, 10:05 PM.
Tags
None
Referenced Files
F15430388: D9868.id23674.diff
Mon, Mar 24, 7:26 AM
F15422529: D9868.id23702.diff
Sat, Mar 22, 9:09 AM
F15392155: D9868.id23674.diff
Sat, Mar 15, 1:32 PM
F15336459: D9868.diff
Sat, Mar 8, 6:58 PM
Unknown Object (File)
Feb 27 2025, 10:07 PM
Unknown Object (File)
Feb 27 2025, 10:07 PM
Unknown Object (File)
Feb 13 2025, 8:02 PM
Unknown Object (File)
Jan 30 2025, 3:21 PM
Subscribers

Details

Summary

We manually quote this in a couple of places. That works fine on Lunix, but does not work on Windows. Instead, explicitly parameterize the command so the correct quoting rules are applied for the OS.

Test Plan

See IRC; windows user had issues fixed by this. arc:upstream still works locally.

Diff Detail

Repository
rARC Arcanist
Branch
pupstream
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1597
Build 1598: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Parameterize `@{upstream}` in arc to fix Windows.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 9 2014, 11:05 PM
epriestley updated this revision to Diff 23702.

Closed by commit rARC0be983a7a334 (authored by @epriestley).