Page MenuHomePhabricator

Parameterize `@{upstream}` in arc to fix Windows
ClosedPublic

Authored by epriestley on Jul 9 2014, 10:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 8, 2:15 PM
Unknown Object (File)
Tue, Dec 24, 2:11 AM
Unknown Object (File)
Thu, Dec 19, 11:14 PM
Unknown Object (File)
Sun, Dec 15, 6:02 AM
Unknown Object (File)
Dec 10 2024, 6:32 PM
Unknown Object (File)
Nov 22 2024, 10:14 AM
Unknown Object (File)
Nov 22 2024, 10:13 AM
Unknown Object (File)
Nov 20 2024, 4:13 PM
Subscribers

Details

Summary

We manually quote this in a couple of places. That works fine on Lunix, but does not work on Windows. Instead, explicitly parameterize the command so the correct quoting rules are applied for the OS.

Test Plan

See IRC; windows user had issues fixed by this. arc:upstream still works locally.

Diff Detail

Repository
rARC Arcanist
Branch
pupstream
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1597
Build 1598: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Parameterize `@{upstream}` in arc to fix Windows.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 9 2014, 11:05 PM
epriestley updated this revision to Diff 23702.

Closed by commit rARC0be983a7a334 (authored by @epriestley).