This got written a while ago and is using slightly incorrect gating on logged-out users. The names of these methods should probably be more clear too, but basically "shouldAllowPublic()" is for "this page may be usable to logged-out users, if policies allow it", while "shouldRequireLogin()" is for "this page should skip various credential checks". One of the skipped checks is email verification. This method should maybe be something like "isAuthenticationRelatedOrNoncredentialPage()" but I don't have a good name for that.
Details
Details
- Reviewers
• chasemp chad - Commits
- Restricted Diffusion Commit
rPfe29db6b92de: Use shouldAllowPublic(), not shouldRequireLogin(), for Legalpad
Unverified users are now prompted to verify email when viewing a legalpad document, instead of allowed to sign it.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- legalpolicy
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 1583 Build 1584: [Placeholder Plan] Wait for 30 Seconds