Ref D8784. Didn't see all of the inlines before hitting arc land. This fixes up the issues raised (and makes all the code nicer).
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- Restricted Diffusion Commit
rP7baa0941b956: Inlines for custom herald actions
Made sure custom actions only appear for appropriate adapters and checked to ensure that they triggered correctly.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
| src/applications/herald/adapter/HeraldAdapter.php | ||
|---|---|---|
| 119 | Not sure if this will throw on duplicates... | |
Comment Actions
This revision should link to the previous one for context - or am I just not seeing it?
Comment Actions
Didn't see all of the inlines before hitting arc land. This fixes up the issues raised (and makes all the code nicer).
Reading this I have to ask myself: Which inlines? Which raised issues?
Hence, I would add a link to the landed Revision/Diff for *context*, so one can answer himself these questions.
If you still feel it would not be useful - so be it.
Comment Actions
If an author doesn't provide a link, you can go to Differential > Advanced Search > Authors > "hach-que" to find stuff they've done recently, which turns up D9796 as the first hit.
Comment Actions
@ite-klass Oh I was assuming since you were subscribed to the previous diff you would have seen it land (via your email or otherwise). It is D8784 for reference.
The important thing is that the functionality has landed; this diff doesn't change the functionality or behaviour, but just consists of some code styling changes.
Comment Actions
(Maybe put the offending key in the exception message too, makes it slightly easier to debug.)
Comment Actions
Yeah, *I*’m fine, but was thinking about others who may get confused (or me in a week). Sorry for the confusion.