Inlines for custom herald actions
ClosedPublic
Actions

Authored by hach-que on Jul 2 2014, 4:43 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP7baa0941b956: Inlines for custom herald actions

Summary

Ref D8784. Didn't see all of the inlines before hitting arc land. This fixes up the issues raised (and makes all the code nicer).

Test Plan

Made sure custom actions only appear for appropriate adapters and checked to ensure that they triggered correctly.

Diff Detail

Repository

rP Phabricator

Branch

herald-inlines

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1494
Build 1494: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que updated this revision to Diff 23510.Jul 2 2014, 4:43 AM

hach-que retitled this revision from to Inlines for custom herald actions.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 2 2014, 4:43 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1483: Diff 23510.Jul 2 2014, 4:44 AM

hach-que updated this object.Jul 2 2014, 4:46 AM

hach-que edited edge metadata.

hach-que added inline comments.

src/applications/herald/adapter/HeraldAdapter.php
119	Not sure if this will throw on duplicates...

This revision should link to the previous one for context - or am I just not seeing it?

The previous diff has been landed; these are just some style changes.

Didn't see all of the inlines before hitting arc land. This fixes up the issues raised (and makes all the code nicer).

Reading this I have to ask myself: Which inlines? Which raised issues?

Hence, I would add a link to the landed Revision/Diff for *context*, so one can answer himself these questions.

If you still feel it would not be useful - so be it.

If an author doesn't provide a link, you can go to Differential > Advanced Search > Authors > "hach-que" to find stuff they've done recently, which turns up D9796 as the first hit.

• edutibau added a subscriber: • edutibau.Jul 2 2014, 8:15 PM

@ite-klass Oh I was assuming since you were subscribed to the previous diff you would have seen it land (via your email or otherwise). It is D8784 for reference.

The important thing is that the functionality has landed; this diff doesn't change the functionality or behaviour, but just consists of some code styling changes.

hach-que updated this object.Jul 2 2014, 8:35 PM

hach-que edited edge metadata.