Page MenuHomePhabricator

Move revision header warnings into custom fields
ClosedPublic

Authored by epriestley on Jul 2 2014, 2:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 3:32 AM
Unknown Object (File)
Sat, Dec 14, 1:01 AM
Unknown Object (File)
Thu, Dec 12, 12:48 PM
Unknown Object (File)
Wed, Dec 4, 9:03 AM
Unknown Object (File)
Tue, Dec 3, 6:53 AM
Unknown Object (File)
Fri, Nov 22, 9:42 AM
Unknown Object (File)
Nov 19 2024, 11:17 PM
Unknown Object (File)
Nov 19 2024, 3:33 PM
Subscribers

Details

Summary

Ref T5495. We currently show one warning in revision headers, about not having any reviewers.

I want to add a second warning (for missing Legalpad signatures). At least one install would like to add custom warnings (see T5495) which are so specific that we can't reasonably cover them in the upstream.

Generalize these header warnings by moving them to CustomField, so I can implement the Legalpad stuff without making a mess and the install in T5495 can use an extension.

Test Plan

Hit all three header states, they look exactly like they did before this change:

Screen_Shot_2014-07-01_at_7.01.13_PM.png (774×1 px, 155 KB)

Diff Detail

Repository
rP Phabricator
Branch
legal1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1480
Build 1480: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Move revision header warnings into custom fields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 2 2014, 5:27 AM
epriestley updated this revision to Diff 23511.

Closed by commit rP5a158b5b1932 (authored by @epriestley).