Page MenuHomePhabricator
Differential D9778

Add a "Can Create Documents" permission for Legalpad
ClosedPublic
Actions

Authored by epriestley on Jun 29 2014, 3:07 PM.
Tags
None
Referenced Files
F14039165: D9778.diff
Mon, Nov 11, 4:13 AM
F14022369: D9778.diff
Wed, Nov 6, 4:53 PM
F13967724: D9778.id23480.diff
Wed, Oct 16, 3:32 PM
F13966082: D9778.id23473.diff
Wed, Oct 16, 6:02 AM
Unknown Object (File)
Oct 3 2024, 2:10 AM
Unknown Object (File)
Oct 3 2024, 2:10 AM
Unknown Object (File)
Oct 3 2024, 2:10 AM
Unknown Object (File)
Oct 3 2024, 2:10 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPea50ac32d366: Add a "Can Create Documents" permission for Legalpad
Required Signatures
L28 Phacility Individual Contributor License Agreement
Summary

Ref T3116. Installs might reasonably want to restrict creation of these documents to actual lawyers or something.

Test Plan

Adjusted policy, tried to create document, set it back, created a document.

Diff Detail

Repository
rP Phabricator
Branch
mlegal4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1457
Build 1457: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 23473.Jun 29 2014, 3:07 PM
epriestley retitled this revision from to Add a "Can Create Documents" permission for Legalpad.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
epriestley added a task: Restricted Maniphest Task.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 29 2014, 3:07 PM
Harbormaster completed remote builds in B1457: Diff 23473.Jun 29 2014, 3:08 PM
epriestley updated this revision to Diff 23474.Jun 29 2014, 3:10 PM
  • Add a "Cancel" button on the create flow.
  • Add a "Manage" crumb on the Document > Manage > Signatures page.
  • Minor copy edit "Update" > "Edit" for consistency.
Harbormaster completed remote builds in B1458: Diff 23474.Jun 29 2014, 3:11 PM
epriestley updated this revision to Diff 23475.Jun 29 2014, 3:11 PM
  • Updating to trigger Herald rule.
Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald TranscriptJun 29 2014, 3:11 PM
Harbormaster completed remote builds in B1459: Diff 23475.Jun 29 2014, 3:12 PM
chad accepted this revision.Jun 29 2014, 7:18 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 29 2014, 7:18 PM
epriestley closed this revision.Jun 29 2014, 7:43 PM
epriestley updated this revision to Diff 23480.

Closed by commit rPea50ac32d366 (authored by @epriestley).

Revision Contents
Changeset List

Diff 23473

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/legalpad/application/PhabricatorApplicationLegalpad.php

Loading...
View Options

src/applications/legalpad/capability/LegalpadCapabilityCreateDocuments.php

Loading...
View Options

src/applications/legalpad/controller/LegalpadDocumentEditController.php

Loading...
View Options

src/applications/legalpad/controller/LegalpadDocumentListController.php

Loading...
Phabricator · Built by Phacility