Page MenuHomePhabricator

Allow Herald to "Require legal signatures" for reviews
ClosedPublic

Authored by epriestley on Jun 29 2014, 12:41 AM.
Tags
None
Referenced Files
F14009079: D9771.diff
Wed, Oct 30, 9:42 AM
F14005617: D9771.id23471.diff
Sun, Oct 27, 4:52 PM
F14002751: D9771.diff
Fri, Oct 25, 9:59 PM
F13959363: D9771.id23460.diff
Mon, Oct 14, 7:02 PM
Unknown Object (File)
Oct 6 2024, 3:16 PM
Unknown Object (File)
Sep 30 2024, 4:04 AM
Unknown Object (File)
Sep 26 2024, 12:22 AM
Unknown Object (File)
Sep 21 2024, 4:20 PM

Details

Reviewers
btrahan
chad
Maniphest Tasks
Restricted Maniphest Task
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPadd7bc418dcb: Allow Herald to "Require legal signatures" for reviews
Summary

Ref T3116. Add a Herald action "Require legal signatures" which requires revision authors to accept legal agreements before their revisions can be accepted.

  • Herald will check which documents the author has signed, and trigger a "you have to sign X, Y, Z" for other documents.
  • If the author has already signed everything, we don't spam the revision -- basically, this only triggers when signatures are missing.
  • The UI will show which documents must be signed and warn that the revision can't be accepted until they're completed.
  • Users aren't allowed to "Accept" the revision until documents are cleared.

Fixes T1157. The original install making the request (Hive) no longer uses Phabricator, and this satisfies our requirements.

Test Plan
  • Added a Herald rule.
  • Created a revision, saw the rule trigger.
  • Viewed as author and non-author, saw field UI (generic for non-author, specific for author), transaction UI, and accept-warning UI.
  • Tried to accept revision.
  • Signed document, saw UI update. Note that signatures don't currently push an update to the revision, but could eventually (like blocking tasks work).
  • Accepted revision.
  • Created another revision, saw rules not add the document (since it's already signed, this is the "no spam" case).

Diff Detail

Event Timeline

epriestley retitled this revision from to Allow Herald to "Require legal signatures" for reviews.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
epriestley added tasks: Restricted Maniphest Task, Restricted Maniphest Task.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 29 2014, 2:50 PM
epriestley updated this revision to Diff 23471.

Closed by commit rPadd7bc418dcb (authored by @epriestley).