Page MenuHomePhabricator

Add a "documents I've signed" view to Legalpad
ClosedPublic

Authored by epriestley on Jun 28 2014, 8:52 PM.
Tags
None
Referenced Files
F14021273: D9769.id23458.diff
Wed, Nov 6, 6:55 AM
F14013054: D9769.id23452.diff
Fri, Nov 1, 11:58 PM
F14013053: D9769.id23451.diff
Fri, Nov 1, 11:58 PM
F14013052: D9769.id23458.diff
Fri, Nov 1, 11:58 PM
F14008323: D9769.id23452.diff
Tue, Oct 29, 7:36 PM
F13964022: D9769.id.diff
Tue, Oct 15, 7:19 PM
F13957587: D9769.id23451.diff
Mon, Oct 14, 10:07 AM
Unknown Object (File)
Oct 9 2024, 8:53 AM
Subscribers

Details

Reviewers
chad
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP5242fb057251: Add a "documents I've signed" view to Legalpad
Summary

Ref T3116. Allow documents to be queried for ones the viewer has signed, and make this the default view.

This also relaxes the versioning stuff a little bit, and stops invalidating signatures on older versions of documents. While I think we should do that eventually, it should be more explicit and have better coordination in the UI. For now, we'll track and show older signatures, but not invalidate them.

I imagine eventually differentiating between "minor edits" (typo / link fixes, for example) and major edits which actually require re-signature.

Test Plan

Screen_Shot_2014-06-28_at_1.51.56_PM.png (898×1 px, 120 KB)

Diff Detail

Repository
rP Phabricator
Branch
legal6
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/policy/rule/PhabricatorPolicyRuleLegalpadSignature.php:18XHP16TODO Comment
Unit
Test Failures
Build Status
Buildable 1447
Build 1447: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed

TimeTest
0 mstestProjectPolicyMembership
0 mstestAdminPolicy
0 mstestAllQueriesBelongToActualApplications
0 mstestCustomPolicyRuleAdministrators
0 mstestCustomPolicyRuleLunarPhase
View Full Test Results (1 Failed · 15 Passed)

Event Timeline

epriestley retitled this revision from to Add a "documents I've signed" view to Legalpad.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: Restricted Maniphest Task.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 28 2014, 10:04 PM
epriestley updated this revision to Diff 23458.

Closed by commit rP5242fb057251 (authored by @epriestley).