Differential D9766

Show signatures in a table instead of an object list
ClosedPublic
Actions

Authored by epriestley on Jun 28 2014, 5:32 PM.

Tags

None

Referenced Files

	F14081021: D9766.diff
	Fri, Nov 22, 6:10 PM

	Unknown Object (File)
	Mon, Nov 18, 12:35 PM

	Unknown Object (File)
	Thu, Nov 14, 2:46 AM

	Unknown Object (File)
	Sun, Nov 10, 8:40 AM

	Unknown Object (File)
	Tue, Nov 5, 8:20 PM

	Unknown Object (File)
	Oct 24 2024, 3:29 AM

	Unknown Object (File)
	Oct 17 2024, 6:13 AM

	Unknown Object (File)
	Oct 13 2024, 4:58 AM

Subscribers

Details

Reviewers

Maniphest Tasks

Restricted Maniphest Task

Commits

Restricted Diffusion Commit
rP8887febd8459: Show signatures in a table instead of an object list

Summary

Ref T3116. Since this UI was written we've moved away from footer icons and made tables work better on mobile. This seems reasonable to use a pure table for. I've also reduced the number of required fields here. Use a table and make this UI accessible.

The "Restricted External Account" stuff is T3732, which I'll tackle next.

Test Plan

Screen_Shot_2014-06-28_at_10.30.07_AM.png (1×1 px, 163 KB)

Diff Detail

Repository

Branch

legal3

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1444
Build 1444: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 23448.Jun 28 2014, 5:32 PM

epriestley retitled this revision from to Show signatures in a table instead of an object list.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: Restricted Maniphest Task.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 28 2014, 5:32 PM

Harbormaster completed remote builds in B1444: Diff 23448.Jun 28 2014, 5:33 PM

chad accepted this revision.Jun 28 2014, 5:43 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 28 2014, 5:43 PM

Yay Tables!

samptable.gif (373×504 px, 12 KB)

Closed by commit rP8887febd8459 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

legalpad/

query/

LegalpadDocumentSignatureSearchEngine.php

121 lines

Diff 23448

src/applications/legalpad/query/LegalpadDocumentSignatureSearchEngine.php

Loading...