Page MenuHomePhabricator

Use ApplicationSearch to search for Legalpad signatures
ClosedPublic

Authored by epriestley on Jun 28 2014, 5:16 PM.
Tags
None
Referenced Files
F13771096: D9765.diff
Sun, Sep 8, 5:20 PM
Unknown Object (File)
Sun, Aug 18, 1:23 PM
Unknown Object (File)
Wed, Aug 14, 2:30 AM
Unknown Object (File)
Jul 27 2024, 9:59 AM
Unknown Object (File)
Jul 23 2024, 3:25 AM
Unknown Object (File)
Jul 20 2024, 8:22 PM
Unknown Object (File)
Jul 20 2024, 8:22 PM
Unknown Object (File)
Jul 20 2024, 8:22 PM
Subscribers

Details

Reviewers
chad
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPd8bba221b52b: Use ApplicationSearch to search for Legalpad signatures
Summary

Ref T3116. Currently, document signatures are just in a big list that you can't search through.

  • Make it easier to check if a specific user has signed.
  • Restrict this UI to users who have edit permission on the document (roughly, you need to be a document manager to see the full signature list).

(It's currently possible to generate a Dashboard panel using this query, but it will just throw an exception. I'm going to leave it like that for now, we might reasonably expose some "view signatures across doucments" UI later so someone can quickly check if a user has signed 5 documents or something.)

Test Plan

Screen_Shot_2014-06-28_at_10.13.35_AM.png (1×1 px, 163 KB)

Diff Detail

Repository
rP Phabricator
Branch
legal2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1443
Build 1443: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Use ApplicationSearch to search for Legalpad signatures.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: Restricted Maniphest Task.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 28 2014, 5:42 PM
epriestley updated this revision to Diff 23455.

Closed by commit rPd8bba221b52b (authored by @epriestley).