Differential D9764

Make document signatures visible to only document owners and signers
ClosedPublic
Actions

Authored by epriestley on Jun 28 2014, 5:01 PM.

Details

Reviewers

chad

Maniphest Tasks

Restricted Maniphest Task

Commits

Restricted Diffusion Commit
rP45d61b711060: Make document signatures visible to only document owners and signers

Summary

Ref T3116. Currently signatures are visible to anyone, but they should be more private than that. Instead, you can see a signature if:

It's a signature on a document you can edit; or
it's your signature.

I'm going to lock down the signatures page a bit in general, but this makes sure that the root policy is correct.

Test Plan

Signed a document.
Viewed signatures of a document.

Diff Detail

Repository

rP Phabricator

Branch

legal1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1442
Build 1442: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 23446.Jun 28 2014, 5:01 PM

epriestley retitled this revision from to Make document signatures visible to only document owners and signers.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: Restricted Maniphest Task.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 28 2014, 5:01 PM

Harbormaster completed remote builds in B1442: Diff 23446.Jun 28 2014, 5:02 PM

chad accepted this revision.Jun 28 2014, 5:05 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 28 2014, 5:05 PM

Closed by commit rP45d61b711060 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

legalpad/

query/

LegalpadDocumentSignatureQuery.php

37 lines

storage/

LegalpadDocumentSignature.php

21 lines

Diff 23446

View Options

src/applications/legalpad/query/LegalpadDocumentSignatureQuery.php