Shaves a pixel for use in ObjectLists.
Details
Details
- Reviewers
epriestley - Commits
- Restricted Diffusion Commit
rPe096a227db1d: Slimmer Shade Tags
UIExamples.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- slim-shady-css
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 1417 Build 1417: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
erm, wait did I just make this for nothing, looks like the obj list shades are already smaller?
| webroot/rsrc/css/phui/phui-tag-view.css | ||
|---|---|---|
| 319–346 | I have hard-coded rules down here which were my coarse pass at this, but the explicit slimming is better and your numbers are a little different (and presumably superior). | |
Comment Actions
I'll shoot you a diff to swap over to this and toss out my rules, but I'm going to try Shovel Knight first.
shovel shovel shovel
Comment Actions
Yes, but it's the same size as where I wanted to replace (ObjList) so it's not actually slimmer there.
Here is another pass (shaves another 2px: