Page MenuHomePhabricator
Differential D9734

Move Legalpad signature form inline in document
ClosedPublic
Actions

Authored by epriestley on Jun 25 2014, 9:06 PM.
Tags
None
Referenced Files
F13816977: D9734.diff
Thu, Sep 19, 8:49 PM
Unknown Object (File)
Wed, Sep 4, 8:10 AM
Unknown Object (File)
Sat, Aug 31, 2:28 AM
Unknown Object (File)
Tue, Aug 27, 4:48 AM
Unknown Object (File)
Mon, Aug 26, 10:19 PM
Unknown Object (File)
Mon, Aug 26, 1:15 AM
Unknown Object (File)
Sun, Aug 25, 5:31 PM
Unknown Object (File)
Sat, Aug 24, 11:40 PM
View All Files
Subscribers
epriestley

Details

Reviewers
chad
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rPb1a8dbade6fe: Move Legalpad signature form inline in document
Summary

This makes it look a little less weird.

Test Plan

Screen_Shot_2014-06-25_at_2.05.59_PM.png (1×1 px, 120 KB)

Diff Detail

Repository
rP Phabricator
Branch
legal2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1397
Build 1397: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 23368.Jun 25 2014, 9:06 PM
epriestley retitled this revision from to Move Legalpad signature form inline in document.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 25 2014, 9:06 PM
Harbormaster completed remote builds in B1397: Diff 23368.Jun 25 2014, 9:08 PM
chad commandeered this revision.Jun 25 2014, 9:31 PM
chad edited reviewers, added: epriestley; removed: chad.

I'll take a look after I get through tags.

chad added a comment.Jun 25 2014, 9:33 PM

I have a half-baked, get rid of all those purple one-off headers branch in my sandbox. I think there is a no-bleed setting for DocumentView, but I'd have to check.

chad added a comment.Jun 26 2014, 5:00 AM

I don't know what I was thinking, I can't yoink this, can I?

epriestley edited edge metadata.Jun 26 2014, 5:01 AM

You should be able to now, I think. I can rebase it if arc patch is giving you issues, gimmie a sec.

epriestley commandeered this revision.Jun 26 2014, 5:01 AM
epriestley edited reviewers, added: chad; removed: epriestley.

(Yoinking to rebase for you.)

chad accepted this revision.Jun 26 2014, 5:02 AM
chad edited edge metadata.

Just go ahead and land, I can clean it up tomorrow.

This revision is now accepted and ready to land.Jun 26 2014, 5:02 AM
epriestley added a comment.Jun 26 2014, 5:02 AM

works for me

epriestley closed this revision.Jun 26 2014, 5:02 AM
epriestley updated this revision to Diff 23390.

Closed by commit rPb1a8dbade6fe (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
legalpad/
controller/
47 lines

Diff 23368

View Options

src/applications/legalpad/controller/LegalpadDocumentSignController.php

Loading...
Phabricator · Built by Phacility