Page MenuHomePhabricator
Differential D9722

Add an icon rule to Remarkup
ClosedPublic
Actions

Authored by epriestley on Jun 25 2014, 4:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 17, 4:15 PM
Unknown Object (File)
Sat, Jan 11, 4:51 PM
Unknown Object (File)
Sat, Jan 11, 3:35 PM
Unknown Object (File)
Tue, Dec 24, 11:59 PM
Unknown Object (File)
Tue, Dec 24, 5:08 PM
Unknown Object (File)
Dec 17 2024, 4:25 PM
Unknown Object (File)
Dec 16 2024, 2:02 AM
Unknown Object (File)
Dec 13 2024, 8:49 PM
View All Files
Subscribers
epriestley

Details

Reviewers
chad
Maniphest Tasks
T5468: Allow FontAwesome icons to be used in remarkup
Commits
Restricted Diffusion Commit
rPfe4dcd4063b3: Add an icon rule to Remarkup
Summary

Fixes T5468.

Test Plan

See screenshots.

Diff Detail

Repository
rP Phabricator
Branch
iconrule
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1378
Build 1378: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 23338.Jun 25 2014, 4:44 AM
epriestley retitled this revision from to Add an icon rule to Remarkup.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T5468: Allow FontAwesome icons to be used in remarkup.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 25 2014, 4:44 AM
epriestley added a comment.Jun 25 2014, 4:44 AM

Screen_Shot_2014-06-24_at_9.32.08_PM.png (461×642 px, 28 KB)

Screen_Shot_2014-06-24_at_9.43.12_PM.png (337×828 px, 29 KB)

Harbormaster completed remote builds in B1378: Diff 23338.Jun 25 2014, 4:45 AM
chad edited edge metadata.Jun 25 2014, 4:50 AM

Do these render as inline or block?

epriestley updated this revision to Diff 23339.Jun 25 2014, 4:51 AM
epriestley edited edge metadata.
  • Accidentally implemented the rules in the wrong applications.
Harbormaster completed remote builds in B1379: Diff 23339.Jun 25 2014, 4:52 AM
epriestley added a comment.Jun 25 2014, 4:55 AM

They render inline:

Screen_Shot_2014-06-24_at_9.54.42_PM.png (239×480 px, 22 KB)

epriestley added a comment.Jun 25 2014, 4:56 AM

(The one thing you can't do is [[ link | {icon ...} ]] since we don't reinterpret the link name text as remarkup. Fixing that is a giant pain, technically, and I'm not sure it's too valuable.)

chad accepted this revision.Jun 25 2014, 4:56 AM
chad edited edge metadata.

Dark City was a good movie. I should rewatch that.

This revision is now accepted and ready to land.Jun 25 2014, 4:56 AM
epriestley closed this revision.Jun 25 2014, 4:56 AM
epriestley updated this revision to Diff 23340.

Closed by commit rPfe4dcd4063b3 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
differential/
application/
2 lines
macro/
application/
6 lines
remarkup/
72 lines
uiexample/
examples/
481 lines
docs/
user/
userguide/
20 lines
view/
phui/
474 lines

Diff 23338

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/application/PhabricatorApplicationDifferential.php

Loading...
View Options

src/applications/macro/application/PhabricatorApplicationMacro.php

Loading...
View Options

src/applications/macro/remarkup/PhabricatorRemarkupRuleIcon.php

Loading...
View Options

src/applications/uiexample/examples/PHUIIconExample.php

Loading...
View Options

src/docs/user/userguide/remarkup.diviner

Loading...
View Options

src/view/phui/PHUIIconView.php

Loading...
Phabricator · Built by Phacility