Page MenuHomePhabricator
Differential D9707

Move ActionHeaders to PHUI, add ObjectBox Support, new Colors
ClosedPublic
Actions

Authored by chad on Jun 24 2014, 4:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 1, 11:19 PM
Unknown Object (File)
Sun, Dec 15, 9:23 AM
Unknown Object (File)
Wed, Dec 11, 10:22 PM
Unknown Object (File)
Sat, Dec 7, 5:17 PM
Unknown Object (File)
Wed, Dec 4, 6:17 PM
Unknown Object (File)
Nov 27 2024, 3:51 AM
Unknown Object (File)
Nov 23 2024, 11:34 AM
Unknown Object (File)
Nov 23 2024, 8:49 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPf8e7d8f65cc8: Move ActionHeaders to PHUI, add ObjectBox Support, new Colors
Summary

Moves PhabricatorActionHeaderView to PHUIActionHeaderView, adds Red, Green, and Violet colors and extend ObjectBox to take colors and action headers.

Test Plan

Tested new Welcome layout as well as UIExamples, Workboards, and Hovercards

undefined (980×971 px, 180 KB)

Diff Detail

Repository
rP Phabricator
Branch
header-colors
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1360
Build 1360: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 23309.Jun 24 2014, 4:21 PM
chad retitled this revision from to Move ActionHeaders to PHUI, add ObjectBox Support, new Colors.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 24 2014, 4:21 PM
chad edited the test plan for this revision. (Show Details)Jun 24 2014, 4:22 PM
Harbormaster completed remote builds in B1360: Diff 23309.Jun 24 2014, 4:22 PM
epriestley accepted this revision.Jun 24 2014, 4:31 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 24 2014, 4:31 PM
chad closed this revision.Jun 24 2014, 4:39 PM
chad updated this revision to Diff 23310.

Closed by commit rPf8e7d8f65cc8 (authored by @chad).

Revision Contents
Changeset List

PathSize
resources/
celerity/
48 lines
sprite/
gradients/
manifest/
21 lines
src/
8 lines
applications/
config/
controller/
60 lines
conpherence/
controller/
4 lines
dashboard/
engine/
18 lines
feed/
builder/
2 lines
project/
storage/
4 lines
uiexample/
examples/
PHUIActionHeaderExample.php
PhabricatorActionHeaderExample.php
102 lines
infrastructure/
celerity/
12 lines
7 lines
view/
4 lines
layout/
phui/
layout/
PHUIActionHeaderView.php
PhabricatorActionHeaderView.php
37 lines
phui/
2 lines
10 lines
20 lines
4 lines
widget/
hovercard/
2 lines
webroot/
rsrc/
css/
aphront/
6 lines
application/
config/
25 lines
dashboard/
2 lines
feed/
8 lines
profile/
2 lines
layout/
72 lines
2 lines
phui/
layout/
phui-action-list.css
phabricator-action-list-view.css
126 lines
phui/
36 lines
6 lines
12 lines
image/

Diff 23309

View Options

resources/celerity/map.php

Loading...
View Options

resources/sprite/gradients/lightgreen-header.png

Loading...
View Options

resources/sprite/gradients/lightred-header.png

Loading...
View Options

resources/sprite/gradients/lightviolet-header.png

Loading...
View Options

resources/sprite/manifest/gradient.json

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigWelcomeController.php

Loading...
View Options

src/applications/conpherence/controller/ConpherenceWidgetController.php

Loading...
View Options

src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php

Loading...
View Options

src/applications/feed/builder/PhabricatorFeedBuilder.php

Loading...
View Options

src/applications/project/storage/PhabricatorProjectColumn.php

Loading...
View Options

src/applications/uiexample/examples/PHUIActionHeaderExample.php

Loading...
View Options

src/applications/uiexample/examples/PhabricatorActionHeaderExample.php

Loading...
View Options

src/infrastructure/celerity/CelerityResourceTransformer.php

Loading...
View Options

src/infrastructure/celerity/CeleritySpriteGenerator.php

Loading...
View Options

src/view/AphrontDialogView.php

Loading...
View Options

src/view/layout/PhabricatorActionHeaderView.php

Loading...
View Options

src/view/phui/PHUIActionHeaderView.php

Loading...
View Options

src/view/phui/PHUIDocumentView.php

Loading...
View Options

src/view/phui/PHUIHeaderView.php

Loading...
View Options

src/view/phui/PHUIObjectBoxView.php

Loading...
View Options

src/view/phui/PHUIWorkpanelView.php

Loading...
View Options

src/view/widget/hovercard/PhabricatorHovercardView.php

Loading...
View Options

webroot/rsrc/css/aphront/dialog-view.css

Loading...
View Options

webroot/rsrc/css/application/config/config-welcome.css

Loading...
View Options

webroot/rsrc/css/application/dashboard/dashboard.css

Loading...
View Options

webroot/rsrc/css/application/feed/feed.css

Loading...
View Options

webroot/rsrc/css/application/profile/profile-view.css

Loading...
View Options

webroot/rsrc/css/layout/phabricator-action-header-view.css

Loading...
View Options

webroot/rsrc/css/layout/phabricator-action-list-view.css

Loading...
View Options

webroot/rsrc/css/layout/phabricator-hovercard-view.css

Loading...
View Options

webroot/rsrc/css/phui/phui-action-list.css

Loading...
View Options

webroot/rsrc/css/phui/phui-object-box.css

Loading...
View Options

webroot/rsrc/css/phui/phui-workpanel-view.css

Loading...
View Options

webroot/rsrc/css/sprite-gradient.css

Loading...
View Options

webroot/rsrc/image/sprite-gradient.png

Loading...
Phabricator · Built by Phacility