Fix validation of SSH keys with spaces in the comment field
ClosedPublic
Actions

Authored by epriestley on Jun 23 2014, 10:25 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T5449: space in ssh public key comments causes the SSH key input to reject the key as "invalid"

Commits

Restricted Diffusion Commit
rP5dffd8873748: Fix validation of SSH keys with spaces in the comment field

Summary

Fixes T5449. Keys are in the form <type> <key> <comments>, where comments are optional and can have spaces.

Test Plan

Tried these invalid keys:

Empty.
One part.
Invalid type.

Tried these valid keys:

No comment.
Normal comment.
Comment with spaces.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 23287.Jun 23 2014, 10:25 PM

epriestley retitled this revision from to Fix validation of SSH keys with spaces in the comment field.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

epriestley added a task: T5449: space in ssh public key comments causes the SSH key input to reject the key as "invalid".

Herald added a subscriber: epriestley. · View Herald TranscriptJun 23 2014, 10:25 PM

chad accepted this revision.Jun 23 2014, 10:25 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 23 2014, 10:25 PM

Harbormaster completed remote builds in B1350: Diff 23287.Jun 23 2014, 10:26 PM

Closed by commit rP5dffd8873748 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

settings/

panel/

PhabricatorSettingsPanelSSHKeys.php

33 lines

Diff 23288

View Options

src/applications/settings/panel/PhabricatorSettingsPanelSSHKeys.php

Fix validation of SSH keys with spaces in the comment fieldClosedPublicActions