Page MenuHomePhabricator

Fix validation of SSH keys with spaces in the comment field
ClosedPublic

Authored by epriestley on Jun 23 2014, 10:25 PM.
Tags
None
Referenced Files
F19810630: D9701.diff
Tue, Mar 3, 8:43 PM
F19804220: D9701.diff
Mon, Mar 2, 6:05 AM
F19543999: D9701.diff
Jan 23 2026, 1:45 AM
F19543993: D9701.diff
Jan 23 2026, 1:40 AM
F19508320: D9701.id.diff
Jan 10 2026, 3:15 AM
F19506780: D9701.id23288.diff
Jan 9 2026, 5:06 PM
F19506562: D9701.id23287.diff
Jan 9 2026, 4:48 PM
F19470297: D9701.diff
Jan 5 2026, 1:10 PM
Subscribers

Details

Summary

Fixes T5449. Keys are in the form <type> <key> <comments>, where comments are optional and can have spaces.

Test Plan

Tried these invalid keys:

  • Empty.
  • One part.
  • Invalid type.

Tried these valid keys:

  • No comment.
  • Normal comment.
  • Comment with spaces.

Diff Detail

Repository
rP Phabricator
Branch
sshvalidate
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1350
Build 1350: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Fix validation of SSH keys with spaces in the comment field.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 23 2014, 10:25 PM
epriestley updated this revision to Diff 23288.

Closed by commit rP5dffd8873748 (authored by @epriestley).