Better CSS target of inline comments in Pholio
ClosedPublic
Actions

Authored by chad on Jun 22 2014, 6:31 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jan 30, 3:46 PM

	Unknown Object (File)
	Mon, Jan 27, 7:27 AM

	Unknown Object (File)
	Mon, Jan 27, 7:27 AM

	Unknown Object (File)
	Mon, Jan 27, 7:27 AM

	Unknown Object (File)
	Mon, Jan 27, 7:24 AM

	Unknown Object (File)
	Wed, Jan 22, 4:14 AM

	Unknown Object (File)
	Mon, Jan 13, 9:40 PM

	Unknown Object (File)
	Dec 22 2024, 1:48 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rP5c9f0de9db21: Better CSS target of inline comments in Pholio

Summary

Adds a top border only if a comment is preceding.

Test Plan

test inlines with and without commentsy

Diff Detail

Repository

rP Phabricator

Branch

inline-css

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1303
Build 1303: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 23203.Jun 22 2014, 6:31 PM

chad retitled this revision from to Better CSS target of inline comments in Pholio.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 22 2014, 6:31 PM

epriestley accepted this revision.Jun 22 2014, 6:31 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 22 2014, 6:31 PM

Harbormaster completed remote builds in B1303: Diff 23203.Jun 22 2014, 6:32 PM

Closed by commit rP5c9f0de9db21 (authored by @chad).

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

aphront/

transaction.css

7 lines

Diff 23203

View Options

resources/celerity/map.php