Page MenuHomePhabricator
Differential D9658

Replace 'Embed' hint on Pholio
ClosedPublic
Actions

Authored by chad on Jun 22 2014, 5:24 PM.
Tags
None
Referenced Files
F14033665: D9658.diff
Sat, Nov 9, 7:04 PM
F14021061: D9658.diff
Wed, Nov 6, 4:59 AM
F14015509: D9658.id23188.diff
Sun, Nov 3, 7:58 PM
F14015507: D9658.id23198.diff
Sun, Nov 3, 7:57 PM
F13979569: D9658.id23198.diff
Sat, Oct 19, 5:13 AM
Unknown Object (File)
Sep 21 2024, 2:48 AM
Unknown Object (File)
Sep 3 2024, 6:37 PM
Unknown Object (File)
Aug 31 2024, 8:47 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T5384: Change "Embed" subhead in Pholio description to something more useful
Commits
Restricted Diffusion Commit
rP25db3f44a028: Replace 'Embed' hint on Pholio
Summary

Replaces Embed hint with where the heck you are hint.

Test Plan

Tested current and previous mock images.

Diff Detail

Repository
rP Phabricator
Branch
pholio-embed
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1293
Build 1293: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 23188.Jun 22 2014, 5:24 PM
chad retitled this revision from to Replace 'Embed' hint on Pholio.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 22 2014, 5:24 PM
Harbormaster completed remote builds in B1293: Diff 23188.Jun 22 2014, 5:25 PM
epriestley accepted this revision.Jun 22 2014, 6:03 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 22 2014, 6:03 PM
chad closed this revision.Jun 22 2014, 6:09 PM
chad updated this revision to Diff 23198.

Closed by commit rP25db3f44a028 (authored by @chad).

Revision Contents
Changeset List

PathSize
resources/
celerity/
10 lines
src/
applications/
pholio/
view/
8 lines
webroot/
rsrc/
css/
application/
pholio/
4 lines
js/
application/
pholio/
16 lines

Diff 23188

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/pholio/view/PholioMockImagesView.php

Loading...
View Options

webroot/rsrc/css/application/pholio/pholio.css

Loading...
View Options

webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js

Loading...
Phabricator · Built by Phacility