Page MenuHomePhabricator
Differential D9630

Add a masked image to Pholio Inline Comment Dialog
ClosedPublic
Actions

Authored by chad on Jun 19 2014, 4:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 12:01 AM
Unknown Object (File)
Mon, Dec 16, 5:44 PM
Unknown Object (File)
Fri, Dec 13, 8:04 PM
Unknown Object (File)
Thu, Dec 12, 11:07 AM
Unknown Object (File)
Tue, Dec 10, 3:50 PM
Unknown Object (File)
Fri, Dec 6, 12:43 PM
Unknown Object (File)
Wed, Nov 27, 8:16 PM
Unknown Object (File)
Wed, Nov 27, 8:16 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPc3843a9963b6: Add a masked image to Pholio Inline Comment Dialog
Summary

n/a

Test Plan

Tested both ajax and regular pages, test various comments, images.

Screen_Shot_2014-06-19_at_8.57.49_AM.png (469×650 px, 90 KB)

Screen_Shot_2014-06-19_at_9.03.02_AM.png (454×618 px, 142 KB)

Diff Detail

Repository
rP Phabricator
Branch
pholio-dialog
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1241
Build 1241: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 23094.Jun 19 2014, 4:04 PM
chad retitled this revision from to Add a masked image to Pholio Inline Comment Dialog.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 19 2014, 4:04 PM
chad edited the test plan for this revision. (Show Details)Jun 19 2014, 4:04 PM
Harbormaster completed remote builds in B1241: Diff 23094.Jun 19 2014, 4:05 PM
epriestley accepted this revision.Jun 19 2014, 5:49 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 19 2014, 5:49 PM
chad closed this revision.Jun 19 2014, 6:00 PM
chad updated this revision to Diff 23096.

Closed by commit rPc3843a9963b6 (authored by @chad).

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
applications/
pholio/
controller/
53 lines
webroot/
rsrc/
css/
application/
pholio/
8 lines

Diff 23094

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/pholio/controller/PholioInlineController.php

Loading...
View Options

webroot/rsrc/css/application/pholio/pholio-inline-comments.css

Loading...
Phabricator · Built by Phacility