Paths

Table of Contentst

Differential D9580

Don't show description box in Pholio when there isnt one
ClosedPublic
Actions

Authored by chad on Jun 16 2014, 8:18 PM.

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rP125b8dad7bb5: Don't show description box in Pholio when there isnt one

Summary

n/a

Test Plan

Added title and description to 1 of 2 mocks, toggled left and right, saw correct CSS.

Diff Detail

Repository

rP Phabricator

Branch

no-descript

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js:662	W004	JSHintW004

Unit

No Test Coverage

Build Status

Buildable 1150
Build 1150: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 22958.Jun 16 2014, 8:18 PM

chad retitled this revision from to Don't show description box in Pholio when there isnt one.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 16 2014, 8:18 PM

Harbormaster completed remote builds in B1150: Diff 22958.Jun 16 2014, 8:20 PM

JSHint would like var x to appear only once in a function, instead of in each branch:

var x;
if (y) {
  x = a;
} else {
  x = b;
}

This revision is now accepted and ready to land.Jun 17 2014, 11:14 AM

Fix lint

Closed by commit rP125b8dad7bb5 (authored by @chad).

Harbormaster completed remote builds in B1181: Diff 23013.Jun 17 2014, 5:11 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

44 lines

webroot/

rsrc/

js/

application/

pholio/

behavior-pholio-mock-view.js

12 lines

Diff 22958

View Options

resources/celerity/map.php