Support "Projects" field for pholio mocks in Herald
ClosedPublic
Actions

Authored by epriestley on Jun 15 2014, 5:59 PM.

Tags

None

Referenced Files

	F15478873: D9552.id22906.diff
	Tue, Apr 8, 3:32 AM

	F15477959: D9552.id22895.diff
	Mon, Apr 7, 7:15 PM

	F15477936: D9552.id.diff
	Mon, Apr 7, 6:57 PM

	F15474141: D9552.diff
	Sun, Apr 6, 5:37 AM

	F15457332: D9552.diff
	Sun, Mar 30, 3:43 PM

	F15414777: D9552.id.diff
	Thu, Mar 20, 2:31 AM

	F15382404: D9552.diff
	Fri, Mar 14, 12:10 PM

	F15375010: D9552.diff
	Wed, Mar 12, 9:07 PM

View All Files

Subscribers

epriestley

Details

Reviewers

chad

Commits

Restricted Diffusion Commit
rP397d67ff3d08: Support "Projects" field for pholio mocks in Herald

Summary

Mocks can have projects now; allow Herald rules to be written against them.

Test Plan

Wrote a Herald mock rule about projects.

Diff Detail

Repository

rP Phabricator

Branch

pho5

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1116
Build 1116: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 22895.Jun 15 2014, 5:59 PM

epriestley retitled this revision from to Support "Projects" field for pholio mocks in Herald.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 15 2014, 5:59 PM

Harbormaster completed remote builds in B1116: Diff 22895.Jun 15 2014, 6:00 PM

chad accepted this revision.Jun 15 2014, 6:26 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 15 2014, 6:26 PM

Closed by commit rP397d67ff3d08 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

adapter/

HeraldPholioMockAdapter.php

13 lines

Diff 22895

View Options

src/applications/herald/adapter/HeraldPholioMockAdapter.php

Support "Projects" field for pholio mocks in HeraldClosedPublicActions