Page MenuHomePhabricator
Differential D9549

Treat Pholio image descriptions as Remarkup, not plain text
ClosedPublic
Actions

Authored by epriestley on Jun 15 2014, 4:22 PM.
Tags
None
Referenced Files
F13808858: D9549.id.diff
Tue, Sep 17, 3:25 AM
Unknown Object (File)
Sun, Sep 15, 7:19 AM
Unknown Object (File)
Mon, Sep 9, 7:47 PM
Unknown Object (File)
Sun, Sep 1, 2:04 AM
Unknown Object (File)
Thu, Aug 29, 4:52 PM
Unknown Object (File)
Thu, Aug 29, 4:47 PM
Unknown Object (File)
Sat, Aug 24, 1:01 PM
Unknown Object (File)
Fri, Aug 23, 12:38 PM
View All Files
Subscribers
epriestley

Details

Reviewers
chad
Maniphest Tasks
T5283: Support markdown in descriptions of individual Pholio images
Commits
Restricted Diffusion Commit
rP77efdb6f3594: Treat Pholio image descriptions as Remarkup, not plain text
Summary

Fixes T5283.

Test Plan

See screenshots.

Diff Detail

Repository
rP Phabricator
Branch
pho3
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1112
Build 1112: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 22886.Jun 15 2014, 4:22 PM
epriestley retitled this revision from to Treat Pholio image descriptions as Remarkup, not plain text.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T5283: Support markdown in descriptions of individual Pholio images.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 15 2014, 4:22 PM
Harbormaster completed remote builds in B1112: Diff 22886.Jun 15 2014, 4:23 PM
epriestley added a comment.EditedJun 15 2014, 4:23 PM

Mock view might need some tweaking. I moved it down to the bottom so the download/full-screen buttons can be fixed-height and the header kind of thing can be sort of header-ey.

Screen_Shot_2014-06-15_at_9.21.30_AM.png (306×986 px, 21 KB)

Screen_Shot_2014-06-15_at_9.21.40_AM.png (482×1 px, 29 KB)

chad accepted this revision.Jun 15 2014, 5:23 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 15 2014, 5:23 PM
epriestley closed this revision.Jun 15 2014, 5:27 PM
epriestley updated this revision to Diff 22888.

Closed by commit rP77efdb6f3594 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
resources/
celerity/
42 lines
src/
applications/
pholio/
view/
9 lines
2 lines
webroot/
rsrc/
css/
application/
pholio/
1 line
5 lines
js/
application/
pholio/
13 lines

Diff 22886

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/pholio/view/PholioMockImagesView.php

Loading...
View Options

src/applications/pholio/view/PholioUploadedImageView.php

Loading...
View Options

webroot/rsrc/css/application/pholio/pholio-edit.css

Loading...
View Options

webroot/rsrc/css/application/pholio/pholio.css

Loading...
View Options

webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js

Loading...
Phabricator · Built by Phacility