Page MenuHomePhabricator

Allow the Pholio stage to scroll vertically
ClosedPublic

Authored by epriestley on Jun 15 2014, 1:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 6, 1:49 AM
Unknown Object (File)
Tue, Dec 3, 5:12 PM
Unknown Object (File)
Fri, Nov 29, 12:49 PM
Unknown Object (File)
Tue, Nov 19, 11:24 PM
Unknown Object (File)
Nov 16 2024, 1:27 PM
Unknown Object (File)
Nov 11 2024, 10:04 PM
Unknown Object (File)
Nov 8 2024, 8:05 AM
Unknown Object (File)
Nov 1 2024, 2:42 PM
Subscribers

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rP8b1b52ea70cf: Allow the Pholio stage to scroll vertically
Summary

Currently, we limit the image size to make sure that the stage has a constant height and the entire image always fits on screen.

In practice, these don't actually seem like desirable qualities. Instead, focus on giving as many pixels as possible to the image.

Test Plan

See screenshots.

Diff Detail

Repository
rP Phabricator
Branch
inlines4
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1098
Build 1098: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Allow the Pholio stage to scroll vertically.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

Before, if the image was too tall to fit on screen without scrolling, we would resize it vertically to fit it on screen:

Screen_Shot_2014-06-14_at_6.51.33_PM.png (614×1 px, 249 KB)

Instead, only resize the image if it would need to scroll horizontally:

Screen_Shot_2014-06-14_at_6.51.43_PM.png (614×1 px, 303 KB)

We might still want a 'Full Size' JS button when it's scale, but it could be this resolves 95% of complaints.

chad edited edge metadata.
This revision is now accepted and ready to land.Jun 15 2014, 2:04 AM
epriestley updated this revision to Diff 22866.

Closed by commit rP8b1b52ea70cf (authored by @epriestley).