Page MenuHomePhabricator
Differential D9538

Completely remove Pholio right gutter
ClosedPublic
Actions

Authored by epriestley on Jun 15 2014, 1:35 AM.
Tags
None
Referenced Files
F14478429: D9538.diff
Sat, Dec 28, 5:58 PM
F14477143: D9538.diff
Sat, Dec 28, 12:11 PM
Unknown Object (File)
Sun, Dec 22, 4:53 PM
Unknown Object (File)
Thu, Dec 19, 5:50 AM
Unknown Object (File)
Tue, Dec 3, 8:08 PM
Unknown Object (File)
Tue, Dec 3, 5:12 PM
Unknown Object (File)
Mon, Dec 2, 11:23 AM
Unknown Object (File)
Nov 27 2024, 1:35 AM
View All Files
Subscribers
epriestley

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rP0cc0782eaf8d: Completely remove Pholio right gutter
Summary
  • Moves the right-hand gutter under the image.
  • Moves size information to the upper right.
  • This is transitional, on the way toward something more like the mocks in D9534.
Test Plan

See screenshot.

Diff Detail

Repository
rP Phabricator
Branch
inlines3
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1096
Build 1096: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 22859.Jun 15 2014, 1:35 AM
epriestley retitled this revision from to Completely remove Pholio right gutter.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 15 2014, 1:35 AM
epriestley added a comment.Jun 15 2014, 1:36 AM

Here's a screen:

Screen_Shot_2014-06-14_at_6.33.49_PM.png (1×1 px, 767 KB)

Harbormaster completed remote builds in B1096: Diff 22859.Jun 15 2014, 1:36 AM
epriestley added inline comments.Jun 15 2014, 1:38 AM
webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js
159–160

(I haven't rebased on your changes yet, this is probably a little different after rebase.)

epriestley added a comment.Jun 15 2014, 1:41 AM

Oh, looks like the checkers are light now. Let me make the text dark, I suppose?

chad edited edge metadata.Jun 15 2014, 1:43 AM

Oh haha I am derp. Didn't mean to commit that until we went all light

epriestley added a comment.Jun 15 2014, 1:45 AM

Haha, okay. I'll swap it back to dark. Here was the light version:

Screen_Shot_2014-06-14_at_6.44.56_PM.png (1×1 px, 607 KB)

epriestley updated this revision to Diff 22862.Jun 15 2014, 1:47 AM
epriestley edited edge metadata.
  • Rebased, dark background.
epriestley added a comment.Jun 15 2014, 1:47 AM

Screen_Shot_2014-06-14_at_6.46.48_PM.png (1×1 px, 609 KB)

Harbormaster completed remote builds in B1097: Diff 22862.Jun 15 2014, 1:48 AM
chad accepted this revision.Jun 15 2014, 2:03 AM
chad edited edge metadata.

I got to get kids to bed, then I can get back to making Pholio worse tonight.

This revision is now accepted and ready to land.Jun 15 2014, 2:03 AM
epriestley added a comment.Jun 15 2014, 2:22 AM

Lyuba is going to the opera so I'm pretty sure we can completely destroy this application tonight.

epriestley closed this revision.Jun 15 2014, 2:23 AM
epriestley updated this revision to Diff 22865.

Closed by commit rP0cc0782eaf8d (authored by @epriestley).

Revision Contents
Changeset List

PathSize
resources/
celerity/
52 lines
src/
applications/
pholio/
view/
23 lines
webroot/
rsrc/
css/
application/
pholio/
11 lines
21 lines
js/
application/
pholio/
73 lines

Diff 22859

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/pholio/view/PholioMockImagesView.php

Loading...
View Options

webroot/rsrc/css/application/pholio/pholio-inline-comments.css

Loading...
View Options

webroot/rsrc/css/application/pholio/pholio.css

Loading...
View Options

webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js

Loading...
Phabricator · Built by Phacility