Changes the old dark embed to match the PinboardView. Retains ability to target individual files. Removes "carousel" of files (not super useful?)
Details
Details
- Reviewers
epriestley - Commits
- Restricted Diffusion Commit
rPf801c8fed9e0: Use PHUIPinboard UI for embedding Pholio Mocks
Tested embedding Mocks, with and without targeting specific files. Tested Pholio Pinboard, Macro Pinboard.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- pholio-embed
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 1087 Build 1087: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
If we do want the carousel at some point, maybe it could be a feature of this view (e.g., some hover/click-to-preview kind of thing) so that every UI benefits from it. But I agree that it's not terribly useful.