Fix board links in TaskDetail
ClosedPublic
Actions

Authored by chad on Jun 13 2014, 8:18 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T5361: Board links in Tasks no longer link to Boards

Commits

Summary

Not sure if this is the correct fix, but I think it's where you intend to go?

Test Plan

Click on link in Task, get the the correct board. Click lots of links of boards and make sure everything still works.

Repository

rP Phabricator

Branch

slug-avenue

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1069
Build 1069: [Placeholder Plan] Wait for 30 Seconds

chad retitled this revision from to Fix board links in TaskDetail.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

This prevents a project from being called #board.

Instead, I think it's sufficient to replace tag/ with project/board/?

src/applications/maniphest/controller/ManiphestTaskDetailController.php
567–568	That is, just change this line?

Wouldn't I still need a route to translate the slug? I'm not good with routes.

Sorry, yeah, realized I am crazy. How about this?

src/applications/maniphest/controller/ManiphestTaskDetailController.php
567–568	Then this should just be `$handle->getURI().'board/'`?
src/applications/project/application/PhabricatorApplicationProject.php
82	Make this `/slug/board/` instead of `/board/slug/`.