Page MenuHomePhabricator
Differential D9496

Implement showing buildable status in Diffusion
ClosedPublic
Actions

Authored by hach-que on Jun 12 2014, 7:05 AM.
Tags
None
Referenced Files
F14063243: D9496.diff
Mon, Nov 18, 5:27 PM
F14059153: D9496.diff
Sun, Nov 17, 5:54 PM
F14046427: D9496.diff
Wed, Nov 13, 9:07 PM
F14040393: D9496.id22804.diff
Mon, Nov 11, 9:48 AM
F14034347: D9496.diff
Sat, Nov 9, 11:46 PM
F14027636: D9496.id22752.diff
Fri, Nov 8, 8:18 AM
F14015599: D9496.id.diff
Sun, Nov 3, 10:00 PM
F14004965: D9496.id22806.diff
Sun, Oct 27, 6:09 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rPed76c2be1d8d: Implement showing buildable status in Diffusion
Summary

This implements showing the buildable status in Diffusion and unifies some of the logic used to calculate and render build and buildable statuses.

Test Plan

Looked at diffs and commits with statuses, they rendered fine. Looked at Diffusion and saw buildable status appear (with a manual buildable and manual buildables included in the query).

Diff Detail

Repository
rP Phabricator
Branch
arcpatch-D9496
Lint
Lint Skipped
Unit
No Test Coverage
Build Status
Buildable 1055
Build 1055: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que updated this revision to Diff 22752.Jun 12 2014, 7:05 AM
hach-que retitled this revision from to Move icon / color calculation for Harbormaster build status into static methods.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 12 2014, 7:05 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1026: Diff 22752.Jun 12 2014, 7:06 AM
hach-que updated this revision to Diff 22800.Jun 13 2014, 4:03 PM
hach-que edited edge metadata.

Also implement Diffusion history view

Harbormaster completed remote builds in B1054: Diff 22800.Jun 13 2014, 4:04 PM
hach-que retitled this revision from Move icon / color calculation for Harbormaster build status into static methods to Implement showing buildable status in Diffusion.Jun 13 2014, 4:04 PM
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)

diffusionbuildable.png (764×944 px, 159 KB)

epriestley edited edge metadata.Jun 13 2014, 4:07 PM

One minor inline.

src/applications/diffusion/view/DiffusionHistoryTableView.php
220

This should be written PHUI::MARGIN_SMALL_RIGHT or similar.

epriestley accepted this revision.Jun 13 2014, 4:09 PM
epriestley edited edge metadata.

Let's move the column and just show an icon, but this is good after that change. Thanks!

This revision is now accepted and ready to land.Jun 13 2014, 4:09 PM
hach-que updated this revision to Diff 22801.Jun 13 2014, 4:13 PM
hach-que edited edge metadata.

Update appearance of build icon

hach-que added a comment.Jun 13 2014, 4:13 PM

diffusionbuildable1.png (764×944 px, 148 KB)

Harbormaster completed remote builds in B1055: Diff 22801.Jun 13 2014, 4:14 PM
hach-que updated this revision to Diff 22803.Jun 13 2014, 4:14 PM

Use constant

Harbormaster completed remote builds in B1056: Diff 22803.Jun 13 2014, 4:15 PM
hach-que updated this revision to Diff 22804.Jun 13 2014, 4:22 PM

Move icon to the right

Herald added a reviewer: chad. · View Herald TranscriptJun 13 2014, 4:22 PM
hach-que added a comment.Jun 13 2014, 4:23 PM

diffusionbuildable3.png (764×944 px, 155 KB)

Harbormaster completed remote builds in B1057: Diff 22804.Jun 13 2014, 4:24 PM
hach-que updated this revision to Diff 22805.Jun 13 2014, 4:25 PM
hach-que edited edge metadata.

Remove $values[] change

hach-que updated this revision to Diff 22806.Jun 13 2014, 4:25 PM

Fix comma

Harbormaster completed remote builds in B1058: Diff 22805.Jun 13 2014, 4:26 PM
Harbormaster completed remote builds in B1059: Diff 22806.
hach-que closed this revision.Jun 13 2014, 4:28 PM
hach-que updated this revision to Diff 22807.

Closed by commit rPed76c2be1d8d (authored by @hach-que).

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
view/
92 lines
harbormaster/
event/
37 lines
query/
21 lines
storage/
26 lines
build/
39 lines

Diff 22801

View Options

src/applications/diffusion/view/DiffusionHistoryTableView.php

Loading...
View Options

src/applications/harbormaster/event/HarbormasterUIEventListener.php

Loading...
View Options

src/applications/harbormaster/query/HarbormasterBuildableSearchEngine.php

Loading...
View Options

src/applications/harbormaster/storage/HarbormasterBuildable.php

Loading...
View Options

src/applications/harbormaster/storage/build/HarbormasterBuild.php

Loading...
Phabricator · Built by Phacility