Fixes T5308.
- Allows you to create a panel directly on a dashboard.
- Also, include existing panels with a select instead of a text field. This won't scale as well but should be fine for now, and is way easier to use.
Details
Details
- Reviewers
chad - Maniphest Tasks
- T5308: Allow Panels to be created without leaving "Manage Dashboard"
- Commits
- Restricted Diffusion Commit
rP6f4ebcb8d913: Create dashboard panels inline on dashboards
See comment.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- dash3
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 1032 Build 1032: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
"Add Panel" is now two buttons, to create or select a panel:
Selecting a panel gives you a select, instead of a textarea / "type a widget id". This should be fine until installs have many hundreds of panels:
Creating a panel gives you an inline dialog:
Then you make the actual panel:
After the workflow completes, it is added to the dashboard.
| src/applications/dashboard/engine/PhabricatorDashboardRenderingEngine.php | ||
|---|---|---|
| 118 | Yeah, the wording is a little odd here. I was trying to capture "Create Panel (And Add It Here)", but that's probably clear enough from context. I'll clean it up. | |