Page MenuHomePhabricator
Differential D9454

Add white as ActionHeader color, use on Dashboards
ClosedPublic
Actions

Authored by chad on Jun 10 2014, 4:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 15, 5:51 AM
Unknown Object (File)
Tue, Sep 3, 2:14 PM
Unknown Object (File)
Sun, Sep 1, 11:51 AM
Unknown Object (File)
Sat, Aug 24, 4:15 PM
Unknown Object (File)
Sat, Aug 24, 9:46 AM
Unknown Object (File)
Wed, Aug 21, 1:34 PM
Unknown Object (File)
Mon, Aug 19, 4:32 AM
Unknown Object (File)
Aug 18 2024, 1:04 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP12f2ffd46a65: Add white as ActionHeader color, use on Dashboards
Summary

Trying to lessen the visual footprint of a heavy-widget dashboard. Adds a plain style.

Test Plan

Tested my homepage and dashboards

undefined (607×718 px, 131 KB)

Diff Detail

Repository
rP Phabricator
Branch
phui-header
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningwebroot/rsrc/css/layout/phabricator-action-header-view.css:78TXT3Line Too Long
Unit
Tests Passed
Build Status
Buildable 958
Build 958: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 22562.Jun 10 2014, 4:15 PM
chad retitled this revision from to Add white as ActionHeader color, use on Dashboards.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJun 10 2014, 4:15 PM
epriestley accepted this revision.Jun 10 2014, 4:15 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 10 2014, 4:15 PM
chad edited the test plan for this revision. (Show Details)Jun 10 2014, 4:15 PM
chad edited edge metadata.
Harbormaster completed remote builds in B958: Diff 22562.Jun 10 2014, 4:16 PM
chad closed this revision.Jun 10 2014, 4:16 PM
chad updated this revision to Diff 22563.

Closed by commit rP12f2ffd46a65 (authored by @chad).

epriestley added a comment.Jun 10 2014, 4:16 PM

Feels a touch odd at first glance, but I'll whine if I don't get used to it.

chad added a comment.Jun 10 2014, 4:20 PM

Yeah, I think I like it better, but it's hard to tell without living with it for a week.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
applications/
dashboard/
engine/
4 lines
view/
layout/
1 line
webroot/
rsrc/
css/
layout/
17 lines

Diff 22562

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php

Loading...
View Options

src/view/layout/PhabricatorActionHeaderView.php

Loading...
View Options

webroot/rsrc/css/layout/phabricator-action-header-view.css

Loading...
Phabricator · Built by Phacility