Replaces the icons with fonts from FontAwesome. Up in the air about the meme icon. Thoughts?
Also removed the second fullscreen/normal state. Seems obvious what it does, but assume someone complained previously?
Details
Details
- Reviewers
epriestley - Commits
- Restricted Diffusion Commit
rPdbebfea9cc1c: FontAwesome RemarkupBar
Tested all the icon states and made sure they still worked. Test fullscreen and help.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- remarkup
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 874 Build 874: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Yeah, I don't like the Reddit icon. The idea is cute, but using a brand logo feels sketchy to me.
Maybe fa-leaf (this is meaningless, but also the "macro" application icon), fa-lightbulb-o, or fa-gavel (sort of like a stamp, maybe?), or fa-book (select from a list of macros?) or fa-paw? I don't really see any strong candidates.
We could also retain the icon in this case, but that's kind of a pain.